Skip to content

Increase apt timeouts when building the Docker image#13594

Merged
hashhar merged 1 commit intotrinodb:masterfrom
nineinchnick:docker-retries-and-timeouts
Aug 16, 2022
Merged

Increase apt timeouts when building the Docker image#13594
hashhar merged 1 commit intotrinodb:masterfrom
nineinchnick:docker-retries-and-timeouts

Conversation

@nineinchnick
Copy link
Copy Markdown
Member

@nineinchnick nineinchnick commented Aug 10, 2022

Description

The network in the emulated containers seems to be much slower, so timeouts need to be increased. I couldn't find what's the default value, apt-config dump doesn't show it.

Fixes #13589

Is this change a fix, improvement, new feature, refactoring, or other?
fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
ci

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 10, 2022
@nineinchnick nineinchnick force-pushed the docker-retries-and-timeouts branch from 0701041 to 48d701b Compare August 10, 2022 10:11
@nineinchnick
Copy link
Copy Markdown
Member Author

CI hit #13362

@nineinchnick nineinchnick requested review from ebyhr and hashhar August 15, 2022 16:18
@hashhar
Copy link
Copy Markdown
Member

hashhar commented Aug 16, 2022

Add PR description to the commit message please.

The network in the emulated containers seems to be much slower, so
timeouts need to be increased. Retries are added to have explicit
defaults.
@nineinchnick nineinchnick force-pushed the docker-retries-and-timeouts branch from 48d701b to 11a9330 Compare August 16, 2022 07:44
@nineinchnick
Copy link
Copy Markdown
Member Author

@hashhar done

@hashhar hashhar merged commit 79bee3e into trinodb:master Aug 16, 2022
@hashhar hashhar added the no-release-notes This pull request does not require release notes entry label Aug 16, 2022
@github-actions github-actions bot added this to the 393 milestone Aug 16, 2022
@nineinchnick nineinchnick deleted the docker-retries-and-timeouts branch November 2, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

Flaky Test Docker Image step due to ports.ubuntu.com connection timed out

2 participants