Merged
Conversation
This makes the exit paths more natural. Previously we had to special-case on empty map returned from `getMaterializedViewToken` meaning "missing information, assume not fresh".
Before the change, when an Iceberg materialized view was created on a table without any snapshots, the table would be excluded from future staleness checks. Note: Trino does not currently create tables without any initial snapshots. The `CREATE TABLE` in Trino currently creates a table snapshot.
It's to be future-proof and also suppress an error-prone warning. Currently, the returned future is always already completed.
findepi
force-pushed
the
findepi/iceberg-mv-fixups
branch
from
6648520 to
fdcbccd
Compare
Member
Author
|
@ebyhr @raunaqmorarka can you PTAL? |
raunaqmorarka
approved these changes
Aug 12, 2022
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
Would be nice to have a test
Member
Author
discussed offline. @raunaqmorarka will follow-up. thank you! |
Closed
colebow
added
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #13484