Skip to content

Merge same switch branches in DomainTranslator.extractOrderableDomain #13564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 4 commits into from
Aug 10, 2022
Merged

Merge same switch branches in DomainTranslator.extractOrderableDomain #13564

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23fa2e0
Merge same switch branches in DomainTranslator.extractOrderableDomain
findepi Aug 9, 2022
e80ebde
Remove redundant else
findepi Aug 9, 2022
14b8233
empty
findepi Aug 9, 2022
718ca45
empty
findepi Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions core/trino-main/src/main/java/io/trino/sql/planner/DomainTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,51 +683,33 @@ the Domain should consist of ranges (which do not sum to the whole ValueSet), an
if (complement) {
return Optional.empty();
}
else {
return Optional.of(Domain.create(ValueSet.ofRanges(Range.equal(type, value)), false));
}
return Optional.of(Domain.create(ValueSet.ofRanges(Range.equal(type, value)), false));
case GREATER_THAN:
if (complement) {
return Optional.empty();
}
else {
return Optional.of(Domain.create(ValueSet.ofRanges(Range.greaterThan(type, value)), false));
}
return Optional.of(Domain.create(ValueSet.ofRanges(Range.greaterThan(type, value)), false));
case GREATER_THAN_OR_EQUAL:
if (complement) {
return Optional.empty();
}
else {
return Optional.of(Domain.create(ValueSet.ofRanges(Range.greaterThanOrEqual(type, value)), false));
}
return Optional.of(Domain.create(ValueSet.ofRanges(Range.greaterThanOrEqual(type, value)), false));
case LESS_THAN:
if (complement) {
return Optional.empty();
}
else {
return Optional.of(Domain.create(ValueSet.ofRanges(Range.lessThan(type, value)), false));
}
return Optional.of(Domain.create(ValueSet.ofRanges(Range.lessThan(type, value)), false));
case LESS_THAN_OR_EQUAL:
if (complement) {
return Optional.empty();
}
else {
return Optional.of(Domain.create(ValueSet.ofRanges(Range.lessThanOrEqual(type, value)), false));
}
return Optional.of(Domain.create(ValueSet.ofRanges(Range.lessThanOrEqual(type, value)), false));
case NOT_EQUAL:
if (complement) {
return Optional.of(Domain.create(ValueSet.ofRanges(Range.equal(type, value)), false));
}
else {
return Optional.empty();
}
case IS_DISTINCT_FROM:
if (complement) {
return Optional.of(Domain.create(ValueSet.ofRanges(Range.equal(type, value)), false));
}
else {
return Optional.empty();
}
return Optional.empty();
}
throw new AssertionError("Unhandled operator: " + comparisonOperator);
}
Expand Down