Skip to content

Slate Alluxio metastore integration for removal #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Aug 25, 2022
Merged

Slate Alluxio metastore integration for removal #13559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/main/sphinx/connector/hive-alluxio.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ the following:
.. code-block:: text

connector.name=hive
hive.metastore=alluxio
hive.metastore=alluxio-deprecated
hive.metastore.alluxio.master.address=HOSTNAME:PORT

Replace ``HOSTNAME`` with the Alluxio master hostname, and replace ``PORT``
Expand Down
7 changes: 7 additions & 0 deletions plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ public void testAlluxioMetastore()
new TestingConnectorContext()))
.hasMessageMatching("(?s)Unable to create injector, see the following errors:.*" +
"Explicit bindings are required and HiveMetastoreFactory .* is not explicitly bound.*");

assertThatThrownBy(() -> factory.create(
"test",
ImmutableMap.of("hive.metastore", "alluxio-deprecated"),
new TestingConnectorContext()))
.hasMessageMatching("(?s)Unable to create injector, see the following errors:.*" +
"Explicit bindings are required and HiveMetastoreFactory .* is not explicitly bound.*");
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-hive-hadoop2/src/test/java/io/trino/plugin/hive/TestHivePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void testAlluxioMetastore()
factory.create(
"test",
ImmutableMap.of(
"hive.metastore", "alluxio",
"hive.metastore", "alluxio-deprecated",
"hive.metastore.alluxio.master.address", "dummy:1234"),
new TestingConnectorContext())
.shutdown();
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/HiveMetastoreModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ protected void setup(Binder binder)
// Load Alluxio metastore support through reflection. This makes Alluxio effectively an optional dependency
// and allows deploying Trino without the Alluxio jar. Can be useful if the integration is unused and is flagged
// by a security scanner.
bindMetastoreModule("alluxio", deferredModule("io.trino.plugin.hive.metastore.alluxio.AlluxioMetastoreModule"));
bindMetastoreModule("alluxio-deprecated", deferredModule("io.trino.plugin.hive.metastore.alluxio.AlluxioMetastoreModule"));
}

install(new DecoratedHiveMetastoreModule());
Expand Down