Skip to content

Allow all bucketed table supported types during filter#13553

Merged
raunaqmorarka merged 2 commits intotrinodb:masterfrom
gaurav8297:gaurav8297/hive_bucket_varchar
Aug 11, 2022
Merged

Allow all bucketed table supported types during filter#13553
raunaqmorarka merged 2 commits intotrinodb:masterfrom
gaurav8297:gaurav8297/hive_bucket_varchar

Conversation

@gaurav8297
Copy link
Member

@gaurav8297 gaurav8297 commented Aug 8, 2022

Description

Fixes #13472

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

hive connector

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Hive
* Add support for hive bucket filtering to float, double, date, list, map and bounded varchar data types. ({issue}`13553`)

@cla-bot cla-bot bot added the cla-signed label Aug 8, 2022
@gaurav8297 gaurav8297 requested review from electrum and findepi August 8, 2022 20:57
@gaurav8297 gaurav8297 changed the title Allow all bucket supported types during filtering Allow all bucketing supported types during filtering Aug 8, 2022
@findepi findepi requested review from alexjo2144 and ebyhr and removed request for findepi August 8, 2022 21:16
@findepi
Copy link
Member

findepi commented Aug 8, 2022

@gaurav8297 see the CI is not green

@gaurav8297 gaurav8297 marked this pull request as draft August 8, 2022 21:22
@gaurav8297 gaurav8297 changed the title Allow all bucketing supported types during filtering Support bounded varchar type during bucket filtering Aug 8, 2022
@raunaqmorarka raunaqmorarka marked this pull request as ready for review August 9, 2022 06:24
@gaurav8297 gaurav8297 changed the title Support bounded varchar type during bucket filtering Allow all bucketing supported types during filter Aug 9, 2022
@gaurav8297 gaurav8297 changed the title Allow all bucketing supported types during filter Allow all bucketed table supported types during filter Aug 9, 2022
@raunaqmorarka
Copy link
Member

Error prone check failures are related

@gaurav8297
Copy link
Member Author

#13600 Due to this flaky test, plugin/trino-hive is failing.

@raunaqmorarka raunaqmorarka merged commit 77ebd30 into trinodb:master Aug 11, 2022
@github-actions github-actions bot added this to the 393 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Bucketing on bounded varchars is not used

4 participants