Skip to content

Fix deprecated Parquet OriginalType#13549

Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom
nevillelyh:neville/parquet-original-type
Aug 19, 2022
Merged

Fix deprecated Parquet OriginalType#13549
raunaqmorarka merged 1 commit intotrinodb:masterfrom
nevillelyh:neville/parquet-original-type

Conversation

@nevillelyh
Copy link
Copy Markdown
Member

@nevillelyh nevillelyh commented Aug 8, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Replace deprecated Parquet OriginalType with LogicalTypeAnnotation

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

lib/trino-parquet and plugin/trino-hive connector

How would you describe this change to a non-technical end user or system administrator?

Fix deprecated Parquet API usage

Related issues, pull requests, and links

Part of #1802

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 8, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nevillelyh nevillelyh changed the title neville/parquet original type Fix deprecated Parquet OriginalType #1802 Aug 8, 2022
@nevillelyh nevillelyh force-pushed the neville/parquet-original-type branch from 599bc28 to 156f2ba Compare August 8, 2022 19:21
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 8, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nevillelyh nevillelyh changed the title Fix deprecated Parquet OriginalType #1802 Fix deprecated Parquet OriginalType Aug 9, 2022
@nevillelyh nevillelyh force-pushed the neville/parquet-original-type branch from 156f2ba to 32ee7db Compare August 9, 2022 13:48
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 9, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@findepi
Copy link
Copy Markdown
Member

findepi commented Aug 9, 2022

cc @alexjo2144 @electrum

- Replace OriginalType with LogicalTypeAnnotation whenever possible
- Kept parts of MessageTypeConverter and MetadataReader since they're
  needed for compatibility reasons
@nevillelyh nevillelyh force-pushed the neville/parquet-original-type branch from 32ee7db to c64dca8 Compare August 18, 2022 21:02
@cla-bot cla-bot bot added the cla-signed label Aug 18, 2022
@nevillelyh
Copy link
Copy Markdown
Member Author

@raunaqmorarka CLA approved & everything passed excepted one due to possibly network issue?

@raunaqmorarka
Copy link
Copy Markdown
Member

@raunaqmorarka CLA approved & everything passed excepted one due to possibly network issue?

I've triggered a re-run of that job

Copy link
Copy Markdown
Member

@skrzypo987 skrzypo987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@raunaqmorarka raunaqmorarka merged commit 6676c28 into trinodb:master Aug 19, 2022
@github-actions github-actions bot added this to the 394 milestone Aug 19, 2022
@nevillelyh nevillelyh deleted the neville/parquet-original-type branch August 22, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants