Skip to content

Comments

Add MERGE to SQL support documentation#13548

Merged
martint merged 1 commit intotrinodb:masterfrom
jhlodin:jl/sql-merge-connectors
Aug 17, 2022
Merged

Add MERGE to SQL support documentation#13548
martint merged 1 commit intotrinodb:masterfrom
jhlodin:jl/sql-merge-connectors

Conversation

@jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Aug 8, 2022

Description

Add links to the new SQL MERGE statement to the appropriate documentation

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

Document which connectors support SQL MERGE

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@jhlodin jhlodin force-pushed the jl/sql-merge-connectors branch from 50cc7d6 to 4cfb837 Compare August 8, 2022 19:24
Copy link
Member

@djsagain djsagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@mosabua
Copy link
Member

mosabua commented Aug 15, 2022

So odd how this was implemented in the object storage connectors and kudu ..

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure this gets in before the 393 release since that ships the merge command and without this PR the documentation will be misleading

@martint martint merged commit 6f370a8 into trinodb:master Aug 17, 2022
@jhlodin jhlodin deleted the jl/sql-merge-connectors branch August 17, 2022 19:18
@github-actions github-actions bot added this to the 393 milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants