Skip to content

Use text blocks for multiline queries in BaseDeltaLakeConnectorSmokeTest#13543

Closed
findinpath wants to merge 1 commit intotrinodb:masterfrom
findinpath:base-delta-lake-connector-smoke-tests-text-blocks
Closed

Use text blocks for multiline queries in BaseDeltaLakeConnectorSmokeTest#13543
findinpath wants to merge 1 commit intotrinodb:masterfrom
findinpath:base-delta-lake-connector-smoke-tests-text-blocks

Conversation

@findinpath
Copy link
Copy Markdown
Contributor

Description

Draft used for having an overview of how using text blocks for the multilined SQL queries would improve the readability of the tests.

Is this change a fix, improvement, new feature, refactoring, or other?
Code cosmetics

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

N/A

How would you describe this change to a non-technical end user or system administrator?

N/A

@cla-bot cla-bot bot added the cla-signed label Aug 8, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Aug 8, 2022

CI failure seems related to this change.

Error:  io.trino.plugin.deltalake.TestDeltaLakeLegacyWriterConnectorSmokeTest.testCreatePartitionedTableAs  Time elapsed: 1.275 s  <<< FAILURE!
org.junit.ComparisonFailure: 
expected:<...,
   comment varchar[])
WITH (
   location...> but was:<...,
   comment varchar[
])
WITH (
   location...>
...

@findinpath findinpath force-pushed the base-delta-lake-connector-smoke-tests-text-blocks branch from 2504911 to 4a87bad Compare August 9, 2022 07:24
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Aug 16, 2022

I guess the failure hit checkstyle/checkstyle#11742 and we need to wait airlift/airbase#323

Error:  src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java:[323] (regexp) RegexpMultiline: Whitespace character before closing parenthesis
Error:  src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java:[457] (regexp) RegexpMultiline: Whitespace character before closing parenthesis
Error:  src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java:[1256] (regexp) RegexpMultiline: Whitespace character before closing parenthesis

@findinpath findinpath closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants