Skip to content

Fix compilation errors with Eclipse compiler #13532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martint merged 1 commit into from
Sep 19, 2022
Merged

Fix compilation errors with Eclipse compiler #13532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/trino-spi/src/main/java/io/trino/spi/predicate/TupleDomain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,10 @@ public static <T> TupleDomain<T> intersect(List<? extends TupleDomain<? extends
}

@SuppressWarnings("unchecked")
private static <U, T extends U> TupleDomain<U> upcast(TupleDomain<T> domain)
private static <T> TupleDomain<T> upcast(TupleDomain<? extends T> domain)
Copy link
Copy Markdown
Member

@findepi findepi Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a correct simplification.
Was the original code an incorrect Java, according to JLS?

Copy link
Copy Markdown
Member Author

@gzsombor gzsombor Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler complained about the usage:

The method upcast(TupleDomain<T>) in the type TupleDomain<T> is not applicable for the arguments (capture#20-of ? extends TupleDomain<? extends T>)

so it couldn't infer the U type, I'm not sure, if ECJ is too limited, or Javac is more lazy in this case.

Copy link
Copy Markdown
Member

@findepi findepi Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this particular change. In the past, I've seen ECJ having problems where it shouldn't. I don't have any recent experience with this compiler.
Is there any reason you want to use ECJ?

Copy link
Copy Markdown
Member Author

@gzsombor gzsombor Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because this is what Eclipse is using,and a bit annoying that I can't start the app, without fixing the errors 😉

Copy link
Copy Markdown
Member

@martint martint Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible to configure Eclipse to use javac as a compiler?

{
// TupleDomain<T> is covariant with respect to T (because it's immutable), so it's a safe operation
return (TupleDomain<U>) domain;
return (TupleDomain<T>) domain;
}

@SafeVarargs
Expand Down