Skip to content

Minor improvements to ClickHouse doc#13529

Merged
hashhar merged 1 commit intotrinodb:masterfrom
tangjiangling:improve-clickhouse-doc
Aug 8, 2022
Merged

Minor improvements to ClickHouse doc#13529
hashhar merged 1 commit intotrinodb:masterfrom
tangjiangling:improve-clickhouse-doc

Conversation

@tangjiangling
Copy link
Member

@tangjiangling tangjiangling commented Aug 6, 2022

Previously, ClickHouse documentation did not explicitly state:

  1. what parameters users can set via connection-url
  2. how to secretly set connection-password

So this pr:

  • Reference to the parameters supported by connection-url
  • Reference to use secret way to configure connection-password

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Doc improvements.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

ClickHouse doc.

How would you describe this change to a non-technical end user or system administrator?

N/A.

Related issues, pull requests, and links

Fixes #13527

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) No release notes entries required.

- Reference to the parameters supported by `connection-url`
- Reference to use secret way to configure `connection-password`
@tangjiangling
Copy link
Member Author

TODO: We also need to check if other JDBC connectors have the same issue.

@tangjiangling tangjiangling added the no-release-notes This pull request does not require release notes entry label Aug 6, 2022
@ebyhr ebyhr requested review from hashhar and removed request for ebyhr August 7, 2022 00:22
@mosabua
Copy link
Member

mosabua commented Aug 7, 2022

TODO: We also need to check if other JDBC connectors have the same issue.

Feel free to do so .. lots of other connectors will have that snippet already.

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We should probably have similar boilerplate in consistent language in all JDBC connector docs. cc: @mosabua

@hashhar
Copy link
Member

hashhar commented Aug 8, 2022

@tangjiangling I'm merging this one as it is. Please feel free to submit additional PR for other JDBC connectors. Thanks for the improvement.

@hashhar hashhar merged commit e2fffb7 into trinodb:master Aug 8, 2022
@github-actions github-actions bot added this to the 393 milestone Aug 8, 2022
@tangjiangling tangjiangling deleted the improve-clickhouse-doc branch August 8, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed docs no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

How to increase timeout in ClickHouse connector

3 participants