Skip to content

Avoid writing to Hive an empty list of column stats because Hive 2.x fails #13502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Aug 9, 2022
Merged

Avoid writing to Hive an empty list of column stats because Hive 2.x fails #13502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...n/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,9 @@ private void setColumnStatistics(String objectName, List<ColumnStatisticsObj> st
verify(!dateStatistics.isEmpty() && metastoreSupportsDateStatistics.equals(Optional.empty()));

try (ThriftMetastoreClient client = createMetastoreClient()) {
saveColumnStatistics.call(client, statisticsExceptDate);
if (!statisticsExceptDate.isEmpty()) {
Copy link
Copy Markdown
Member

@ebyhr ebyhr Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a product test? I confirmed we can reproduce the issue in EnvSinglenode.

saveColumnStatistics.call(client, statisticsExceptDate);
}

try {
saveColumnStatistics.call(client, dateStatistics);
Expand Down
24 changes: 24 additions & 0 deletions ...rino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveTableStatistics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,6 +1467,30 @@ public Object[][] testComputeFloatingPointStatisticsDataProvider()
};
}

@Test
public void testComputeStatisticsForTableWithOnlyDateColumns()
{
String tableName = "test_compute_statistics_with_only_date_columns";
onTrino().executeQuery("DROP TABLE IF EXISTS " + tableName);
try {
onTrino().executeQuery(format("CREATE TABLE %s AS SELECT date'2019-12-02' c_date", tableName));

List<Row> expectedStatistics = ImmutableList.of(
isHiveVersionBefore12()
? row("c_date", null, null, null, null, null, null)
: row("c_date", null, 1.0, 0.0, null, "2019-12-02", "2019-12-02"),
row(null, null, null, null, 1.0, null, null));

assertThat(onTrino().executeQuery("SHOW STATS FOR " + tableName)).containsOnly(expectedStatistics);

onTrino().executeQuery("ANALYZE " + tableName);
assertThat(onTrino().executeQuery("SHOW STATS FOR " + tableName)).containsOnly(expectedStatistics);
}
finally {
onTrino().executeQuery("DROP TABLE IF EXISTS " + tableName);
}
}

@Test
@Flaky(issue = ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE, match = ERROR_COMMITTING_WRITE_TO_HIVE_MATCH)
public void testMixedHiveAndPrestoStatistics()
Expand Down