Use text blocks for multiline queries in tests#13500
Merged
martint merged 2 commits intotrinodb:masterfrom Aug 7, 2022
Merged
Conversation
The underlying bug was fixed in version 338.
electrum
approved these changes
Aug 4, 2022
ebyhr
approved these changes
Aug 5, 2022
Member
|
Is it a manual or automated change? |
Member
Author
|
It’s a bit of both. You can use an IntelliJ intention to concatenate the strings, but because we don’t use \n it inserts a \s at the end of each line to preserve whitespace. Those have to be removed. The placement of closing quotes also needs to be adjusted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some code cleanup.
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.