Skip to content

[doc] System property required for JMX setup#13466

Closed
honnix wants to merge 4 commits intotrinodb:masterfrom
honnix:patch-1
Closed

[doc] System property required for JMX setup#13466
honnix wants to merge 4 commits intotrinodb:masterfrom
honnix:patch-1

Conversation

@honnix
Copy link
Copy Markdown

@honnix honnix commented Aug 2, 2022

Description

System property required for JMX setup.

Without it, JVM throws an exception complaining:

java.lang.RuntimeException: System property 'com.sun.management.jmxremote.rmi.port=null' does match configured RMI server port 9081

More specifically it is this line: https://github.com/airlift/airlift/blob/master/jmx/src/main/java/io/airlift/jmx/JmxAgent.java#L65

Is this change a fix, improvement, new feature, refactoring, or other?
A doc improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
No.

How would you describe this change to a non-technical end user or system administrator?
NA

Related issues, pull requests, and links

It was first reported by #7843

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 2, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@findepi findepi requested a review from bitsondatadev August 2, 2022 15:23
@honnix
Copy link
Copy Markdown
Author

honnix commented Aug 2, 2022

I'm working the CLA thing.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit .. but we also need a signed CLA to merge. Could you send that?

@honnix
Copy link
Copy Markdown
Author

honnix commented Jul 7, 2023

Minor edit .. but we also need a signed CLA to merge. Could you send that?

Thank you for reminding me of this PR. I will try to get a CLA signed.

Co-authored-by: Manfred Moser <manfred@simpligility.ca>
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jul 7, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jul 10, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jul 10, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jul 10, 2023

Please squash the commits if possible and make sure you send a CLA.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Aug 11, 2023

Can you rebase this into the new jmx.md file and submit a CLA?

@honnix
Copy link
Copy Markdown
Author

honnix commented Aug 12, 2023

Sure I can do that. Unfortunately the CLA is taking too much time to get. If you think this PR is useful, I don't mind at all you applying the change in another PR. @mosabua

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Aug 16, 2023

Linked PR is merged @honnix so this will go live with the 424 release

@honnix honnix deleted the patch-1 branch August 16, 2023 16:10
@honnix
Copy link
Copy Markdown
Author

honnix commented Aug 16, 2023

Thank you @mosabua !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants