Skip to content

Remove use of deprecated Iceberg API method #13440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Aug 1, 2022
Merged

Remove use of deprecated Iceberg API method #13440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4dce34
Remove use of deprecated Iceberg API method
alexjo2144 Aug 1, 2022
8a72f3f
empty
ebyhr Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@ private void removeOrphanFiles(Table table, ConnectorSession session, SchemaTabl
private void removeOrphanMetadataFiles(Table table, ConnectorSession session, SchemaTableName schemaTableName, long expireTimestamp)
{
ImmutableSet<String> manifests = stream(table.snapshots())
.flatMap(snapshot -> snapshot.allManifests().stream())
.flatMap(snapshot -> snapshot.allManifests(table.io()).stream())
.map(ManifestFile::path)
.collect(toImmutableSet());
List<String> manifestLists = ReachableFileUtil.manifestListLocations(table);
Expand Down Expand Up @@ -1721,7 +1721,7 @@ public Optional<ConstraintApplicationResult<ConnectorTableHandle>> applyFilter(C
Table icebergTable = catalog.loadTable(session, table.getSchemaTableName());

Long snapshotId = table.getSnapshotId().orElseThrow(() -> new IllegalStateException("Snapshot id must be present"));
Set<Integer> partitionSpecIds = icebergTable.snapshot(snapshotId).allManifests().stream()
Set<Integer> partitionSpecIds = icebergTable.snapshot(snapshotId).allManifests(icebergTable.io()).stream()
.map(ManifestFile::partitionSpecId)
.collect(toImmutableSet());

Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/ManifestsTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ private static List<Page> buildPages(ConnectorTableMetadata tableMetadata, Table

Map<Integer, PartitionSpec> partitionSpecsById = icebergTable.specs();

snapshot.allManifests().forEach(file -> {
snapshot.allManifests(icebergTable.io()).forEach(file -> {
pagesBuilder.beginRow();
pagesBuilder.appendVarchar(file.path());
pagesBuilder.appendBigint(file.length());
Expand Down