Compatibility fix for Athena Glue#1343
Merged
electrum merged 1 commit intotrinodb:masterfrom Sep 11, 2019
Merged
Conversation
findepi
reviewed
Aug 21, 2019
...e/src/main/java/io/prestosql/plugin/hive/metastore/glue/converter/GlueToPrestoConverter.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/prestosql/plugin/hive/metastore/glue/converter/GlueToPrestoConverter.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/prestosql/plugin/hive/metastore/glue/converter/GlueToPrestoConverter.java
Outdated
Show resolved
Hide resolved
Member
|
Please change commit message to something like |
hgschmie
force-pushed
the
athena-glue-compat-fix
branch
2 times, most recently
from
890d94f to
fab4df9
Compare
electrum
reviewed
Sep 8, 2019
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
Other than using EXTERNAL rather than MANAGED, this looks good.
Glue tables without a table type set are read by AWS Athena and treated as external tables. The same metadata causes Presto to NPE when accessing the table as Presto requires the table type to be set. This change lets Presto treat tables without table type as external tables as well.
hgschmie
force-pushed
the
athena-glue-compat-fix
branch
from
fab4df9 to
b850db7
Compare
Member
Author
|
changed it to "EXTERNAL_TABLE" |
electrum
approved these changes
Sep 10, 2019
Member
|
Merged, thanks! |
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Apr 23, 2021
Cherry pick of Trino trinodb/trino#1343, Athena is fine reading Glue tables that have no table type set. Currently Presto set to default OTHER but Athena tables are external: https://docs.aws.amazon.com/athena/latest/ug/drop-table.html so set the table type to EXTTERNAL if it is unset. Co-authored-by: Henning Schmiedehausen <henning@schmiedehausen.org>
highker
pushed a commit
to prestodb/presto
that referenced
this pull request
May 20, 2021
Cherry pick of Trino trinodb/trino#1343, Athena is fine reading Glue tables that have no table type set. Currently Presto set to default OTHER but Athena tables are external: https://docs.aws.amazon.com/athena/latest/ug/drop-table.html so set the table type to EXTTERNAL if it is unset. Co-authored-by: Henning Schmiedehausen <henning@schmiedehausen.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Athena is fine reading Glue tables that have no table type set. The same table will cause Presto to NPE as the
table type can not be null in presto. This fix will use MANAGED_TABLE if the table type is not set.