Skip to content

Remove redundant override in Iceberg #13425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Aug 2, 2022
Merged

Remove redundant override in Iceberg #13425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,19 +144,13 @@ protected BaseIcebergConnectorTest(IcebergFileFormat format)
this.format = requireNonNull(format, "format is null");
}

protected Map<String, String> additionalIcebergProperties()
{
return ImmutableMap.of();
}

@Override
protected QueryRunner createQueryRunner()
throws Exception
{
return IcebergQueryRunner.builder()
.setIcebergProperties(ImmutableMap.<String, String>builder()
.put("iceberg.file-format", format.name())
.putAll(additionalIcebergProperties())
.buildOrThrow())
.setInitialTables(ImmutableList.<TpchTable<?>>builder()
.addAll(REQUIRED_TPCH_TABLES)
Expand Down
10 changes: 0 additions & 10 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAvroConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,9 @@
*/
package io.trino.plugin.iceberg;

import com.google.common.collect.ImmutableMap;
import io.trino.Session;
import org.testng.SkipException;

import java.util.Map;

import static io.trino.plugin.iceberg.IcebergFileFormat.AVRO;

public class TestIcebergAvroConnectorTest
Expand All @@ -29,13 +26,6 @@ public TestIcebergAvroConnectorTest()
super(AVRO);
}

@Override
protected Map<String, String> additionalIcebergProperties()
{
// Iceberg AVRO doesn't support ZSTD (connector's default) compression codec
return ImmutableMap.of("iceberg.compression-codec", "SNAPPY");
}

@Override
protected boolean supportsIcebergFileStatistics(String typeName)
{
Expand Down