Minor improvement in Pinot config classes#13422
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Aug 1, 2022
Merged
Conversation
hashhar
reviewed
Aug 1, 2022
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotConfig.java
Outdated
Show resolved
Hide resolved
Comment on lines
197
to
208
Member
There was a problem hiding this comment.
The config seems to allow specifying a keystore and truststore type but without any paths to the actual keystore and trust-store. i.e. should we assume if any one of the keystore/truststore property is specified then at-least the keystore/truststore type and path must be present? password is always optional.
Member
There was a problem hiding this comment.
I think we can pass the keystore/truststore type even as Optional variable like we do in Kafka connector. Plus TlsUtils#extractTlsConfig would use a default values if the specific config properties are missing. @hashhar WDYT ?
ebyhr
force-pushed
the
ebi/pinot-config
branch
2 times, most recently
from
9d42405 to
4ec5ee5
Compare
* Use File type in keystorePath and truststorePath * Add missing annotations * Return Optional which the property is nullable
Member
Author
|
@hashhar Updated. |
hashhar
reviewed
Aug 1, 2022
...no-pinot/src/main/java/io/trino/plugin/pinot/client/PinotGrpcServerQueryClientTlsConfig.java
Show resolved
Hide resolved
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor improvement in Pinot config classes
Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text: