Skip to content

Fix formatting#13420

Merged
sopel39 merged 1 commit intotrinodb:masterfrom
starburstdata:ks/fix_formatting
Aug 1, 2022
Merged

Fix formatting#13420
sopel39 merged 1 commit intotrinodb:masterfrom
starburstdata:ks/fix_formatting

Conversation

@sopel39
Copy link
Member

@sopel39 sopel39 commented Jul 29, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@sopel39 sopel39 requested a review from raunaqmorarka July 29, 2022 20:06
@cla-bot cla-bot bot added the cla-signed label Jul 29, 2022
@sopel39 sopel39 requested a review from martint July 29, 2022 20:06
Copy link
Member

@raunaqmorarka raunaqmorarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this being flagged by checkstyle or some linter ?
It seems wasteful to make these kind of formatting "fix"es manually when there is no discernible change to the readability of the code.

@martint
Copy link
Member

martint commented Jul 30, 2022

Why isn't this being flagged by checkstyle or some linter?

Consistency is good, but you can’t have that level of strictness without losing flexibility. Sometimes that flexibility is necessary. Also, I’m not even sure those tools are powerful enough (or compatible) to handle the formatting rules we use for IntelliJ

@sopel39 sopel39 merged commit 8689f5c into trinodb:master Aug 1, 2022
@sopel39 sopel39 deleted the ks/fix_formatting branch August 1, 2022 09:13
@github-actions github-actions bot added this to the 392 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants