Skip to content

Map Druid's float type to Trino's real type #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Praveen2112 merged 2 commits into from
Jul 30, 2022
Merged

Map Druid's float type to Trino's real type #13412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8e917
Fix type in DruidTypeMapping tests
Praveen2112 Jul 29, 2022
1143d89
Map Druid's float type to Trino's real type
Praveen2112 Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/trino-druid/src/main/java/io/trino/plugin/druid/DruidJdbcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,10 @@ public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connect
case Types.BIGINT:
return Optional.of(bigintColumnMapping());

case Types.FLOAT:
case Types.REAL:
return Optional.of(realColumnMapping());

case Types.FLOAT:
case Types.DOUBLE:
return Optional.of(doubleColumnMapping());

Expand Down
21 changes: 9 additions & 12 deletions plugin/trino-druid/src/test/java/io/trino/plugin/druid/TestDruidTypeMapping.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import static io.trino.spi.type.BigintType.BIGINT;
import static io.trino.spi.type.DoubleType.DOUBLE;
import static io.trino.spi.type.RealType.REAL;
import static io.trino.spi.type.TimestampType.TIMESTAMP_MILLIS;
import static io.trino.spi.type.VarcharType.createUnboundedVarcharType;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
Expand Down Expand Up @@ -104,49 +105,45 @@ public void testDoubleNegativeInfinity()
@Test
public void testFloat()
{
//TODO Map Druid's Float data type to Trino's Real data type
SqlDataTypeTest.create()
.addRoundTrip("__time", "timestamp", "2020-01-01 00:00:00.000", TIMESTAMP_MILLIS, "TIMESTAMP '2020-01-01 00:00:00.000'")
.addRoundTrip("col_0", "float", "NULL", DOUBLE, "DOUBLE '0.0'")
.addRoundTrip("col_1", "float", "0.0", DOUBLE, "DOUBLE '0.0'")
.addRoundTrip("col_2", "float", "3.14", DOUBLE, "DOUBLE '3.14'")
.addRoundTrip("col_3", "float", "3.1415927", DOUBLE, "DOUBLE '3.1415927'")
.addRoundTrip("col_4", "float", "Invalid String", DOUBLE, "DOUBLE '0.0'")
.addRoundTrip("col_0", "float", "NULL", REAL, "REAL '0.0'")
.addRoundTrip("col_1", "float", "0.0", REAL, "REAL '0.0'")
.addRoundTrip("col_2", "float", "3.14", REAL, "REAL '3.14'")
.addRoundTrip("col_3", "float", "3.1415927", REAL, "REAL '3.1415927'")
.addRoundTrip("col_4", "float", "Invalid String", REAL, "REAL '0.0'")
.execute(getQueryRunner(), druidCreateAndInsert("test_float"));
}

@Test
public void testFloatNaN()
{
//TODO Map Druid's Float data type to Trino's Real data type
assertThatThrownBy(() ->
SqlDataTypeTest.create()
.addRoundTrip("__time", "timestamp", "2020-01-01 00:00:00.000", TIMESTAMP_MILLIS, "TIMESTAMP '2020-01-01 00:00:00.000'")
.addRoundTrip("col_0", "float", "NaN", DOUBLE, "CAST(nan() AS double)")
.addRoundTrip("col_0", "float", "NaN", REAL, "CAST(nan() AS real)")
.execute(getQueryRunner(), druidCreateAndInsert("test_float_with_nan")))
.hasMessageMatching(".*class java.lang.String cannot be cast to class java.lang.Number.*");
}

@Test
public void testFloatInfinity()
{
//TODO Map Druid's Float data type to Trino's Real data type
assertThatThrownBy(() ->
SqlDataTypeTest.create()
.addRoundTrip("__time", "timestamp", "2020-01-01 00:00:00.000", TIMESTAMP_MILLIS, "TIMESTAMP '2020-01-01 00:00:00.000'")
.addRoundTrip("col_0", "float", "Infinity", DOUBLE, "+infinity()")
.addRoundTrip("col_0", "float", "Infinity", REAL, "+infinity()")
.execute(getQueryRunner(), druidCreateAndInsert("test_float_with_positive_infinity")))
.hasMessageMatching(".*class java.lang.String cannot be cast to class java.lang.Number.*");
}

@Test
public void testFloatNegativeInfinity()
{
//TODO Map Druid's Float data type to Trino's Real data type
assertThatThrownBy(() ->
SqlDataTypeTest.create()
.addRoundTrip("__time", "timestamp", "2020-01-01 00:00:00.000", TIMESTAMP_MILLIS, "TIMESTAMP '2020-01-01 00:00:00.000'")
.addRoundTrip("col_0", "double", "-Infinity", DOUBLE, "-infinity()")
.addRoundTrip("col_0", "float", "-Infinity", REAL, "-infinity()")
.execute(getQueryRunner(), druidCreateAndInsert("test_float_with_negative_infinity")))
.hasMessageMatching(".*class java.lang.String cannot be cast to class java.lang.Number.*");
}
Expand Down