Make createDataPageSource accessible from other classes#13378
Merged
findepi merged 1 commit intotrinodb:masterfrom Jul 27, 2022
Merged
Make createDataPageSource accessible from other classes#13378findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
Member
|
What's the motivation for this change? |
findepi
approved these changes
Jul 27, 2022
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
It is necessary for anyone who creates a modified page source provider.
For example, if you wanted to add indexes or some other split-handling customization you'd need that.
Member
|
Can we add that to the commit message for future reference? |
It is necessary for anyone who creates a modified page source provider, for example with indexes, etc.
findepi
force-pushed
the
homar/make_iceberg_page_source_provider_public
branch
from
a492de2 to
eb903b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: