Skip to content

Fix TestingTrinoServer connector event listener registration#13365

Closed
leveyja wants to merge 2 commits intotrinodb:masterfrom
leveyja:leveyja/trino-testing-server-event-listeners
Closed

Fix TestingTrinoServer connector event listener registration#13365
leveyja wants to merge 2 commits intotrinodb:masterfrom
leveyja:leveyja/trino-testing-server-event-listeners

Conversation

@leveyja
Copy link
Copy Markdown
Member

@leveyja leveyja commented Jul 26, 2022

Description

Taken from #13360

Tests like TestConnectorEventListener.testConnectorEventHandlerReceivingEvents are broken on master because connector's event listeners are never registered when createCatalog is called on TestingTrinoServer (changed since ff323dc)

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

TestingTrinoServer EventListener registration

How would you describe this change to a non-technical end user or system administrator?

Re-enable functionality that was broken by a recent change

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2022
@leveyja leveyja closed this Jul 27, 2022
@leveyja leveyja deleted the leveyja/trino-testing-server-event-listeners branch July 27, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants