Replace Block.getChildren with ColumnarRow#13356
Merged
findepi merged 1 commit intotrinodb:masterfrom Aug 1, 2022
Merged
Conversation
alexjo2144
reviewed
Jul 26, 2022
Member
There was a problem hiding this comment.
Put this outside of the for loop
homar
force-pushed
the
homar/dont_use_block_get_children_in_delta_lake
branch
2 times, most recently
from
c2d3d2a to
63f8c93
Compare
alexjo2144
reviewed
Jul 27, 2022
Member
There was a problem hiding this comment.
You can move this one out as well
Member
Author
There was a problem hiding this comment.
I actually tried that and it made some tests fail with IndexOutOfBound in Block unmodifiedColumns = columnarRow.getField(1);
We have to be in the else branch of the if to be safe to do that
Member
There was a problem hiding this comment.
Right, that might happen if all rows are being updated. You could make the field Optional or nullable. Might be worth it if toColumnarRow might do a meaningful amount of work
homar
force-pushed
the
homar/dont_use_block_get_children_in_delta_lake
branch
2 times, most recently
from
52d122e to
0727444
Compare
Member
Author
|
@alexjo2144 is it ok now ? |
alexjo2144
approved these changes
Aug 1, 2022
Member
Author
|
@findepi can we merge this ? |
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We should not use Block.getChildren(). It is internal routine not intended to use directly. May not work always.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: