Experimental support for distributing catalogs from coordinator to workers#13325
Merged
dain merged 10 commits intotrinodb:masterfrom Aug 12, 2022
Merged
Experimental support for distributing catalogs from coordinator to workers#13325dain merged 10 commits intotrinodb:masterfrom
dain merged 10 commits intotrinodb:masterfrom
Conversation
dain
force-pushed
the
coordinator-distributed-catalogs
branch
4 times, most recently
from
fcfb6b1 to
0324e6f
Compare
electrum
approved these changes
Aug 11, 2022
core/trino-main/src/main/java/io/trino/connector/CatalogProperties.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/CatalogManagerModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/testing/LocalQueryRunner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/CatalogManagerModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/DynamicCatalogManagerModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/FileCatalogStore.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/InMemoryNodeManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/DynamicCatalogManagerModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/DynamicCatalogManagerModule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/DynamicCatalogManagerModule.java
Outdated
Show resolved
Hide resolved
Move support for dynamically adding catalogs from StaticCatalogManager to new DynamicCatalogManager. This is only used in testing and moving this feature makes future enhancements simpler.
dain
force-pushed
the
coordinator-distributed-catalogs
branch
from
0324e6f to
f63bd5e
Compare
Member
Author
|
Test failures in Iceberg are unrelated and reproducible on trunk |
Member
|
Just confirming that we don't want this in release notes / docs yet. And is there a plan to eventually publicize it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds experimental support for distributing catalog configurations from the coordinator to workers.
This works by attaching the configs for the used catalog in the query to worker task creation message. There is no way to remove (or add) catalogs at runtime, but that is ok since there are no commands to add or remove a catalog, which means there should never be a conflict. To try this out, set the following property:
Related issues, pull requests, and links
This is a base feature for Dynamic Catalogs
Documentation
(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(X) No release notes entries required.
( ) Release notes entries required with the following suggested text: