Skip to content

Fix query completion timout in EventsAwaitingQueries#13321

Merged
dain merged 1 commit intotrinodb:masterfrom
dain:fix-query-events-collector
Jul 23, 2022
Merged

Fix query completion timout in EventsAwaitingQueries#13321
dain merged 1 commit intotrinodb:masterfrom
dain:fix-query-events-collector

Conversation

@dain
Copy link
Copy Markdown
Member

@dain dain commented Jul 23, 2022

Description

The timeout was lowered during testing and accidentally committed.

Documentation

(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(X) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Jul 23, 2022
@raunaqmorarka
Copy link
Copy Markdown
Member

Test failure looks related

Error:  io.trino.execution.TestConnectorEventListener.testConnectorEventHandlerReceivingEvents  Time elapsed: 13.853 s  <<< FAILURE!
java.util.concurrent.TimeoutException: Query did not complete in 30.00s
	at io.trino.execution.EventsCollector$QueryEvents.waitForQueryCompletion(EventsCollector.java:142)
	at io.trino.execution.EventsAwaitingQueries.runQueryAndWaitForEvents(EventsAwaitingQueries.java:81)
	at io.trino.execution.EventsAwaitingQueries.runQueryAndWaitForEvents(EventsAwaitingQueries.java:49)
	at io.trino.execution.TestConnectorEventListener.testConnectorEventHandlerReceivingEvents(TestConnectorEventListener.java:73)

@dain
Copy link
Copy Markdown
Member Author

dain commented Jul 23, 2022

There is still something going on with this test, but this is definitely better so I'll merge this.

@dain dain merged commit 1e7d89c into trinodb:master Jul 23, 2022
@dain dain deleted the fix-query-events-collector branch July 23, 2022 18:43
@github-actions github-actions bot added this to the 392 milestone Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants