Add config for the caching duration of Delta table active data files#13316
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Jul 27, 2022
Merged
Add config for the caching duration of Delta table active data files#13316ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
findinpath
force-pushed
the
delta-live-files-cache-ttl
branch
from
91a8103 to
95783c0
Compare
findinpath
force-pushed
the
delta-live-files-cache-ttl
branch
from
95783c0 to
f4aeba0
Compare
findinpath
force-pushed
the
delta-live-files-cache-ttl
branch
2 times, most recently
from
7393dbb to
05c4ecb
Compare
ebyhr
reviewed
Jul 26, 2022
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestTransactionLogAccess.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
delta-live-files-cache-ttl
branch
2 times, most recently
from
99549a0 to
5cd0292
Compare
ebyhr
reviewed
Jul 26, 2022
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestTransactionLogAccess.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TrackingHdfsEnvironment.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TrackingHdfsEnvironment.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
delta-live-files-cache-ttl
branch
from
5cd0292 to
7ba6c68
Compare
ebyhr
reviewed
Jul 27, 2022
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogAccess.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestTransactionLogAccess.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Jul 27, 2022
.../trino-delta-lake/src/test/java/io/trino/plugin/deltalake/AccessTrackingHdfsEnvironment.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
delta-live-files-cache-ttl
branch
from
7ba6c68 to
50c643d
Compare
findinpath
commented
Jul 27, 2022
| * - ``delta.metadata.live-files.cache-ttl`` | ||
| - Caching duration for active files which correspond to the Delta Lake | ||
| tables. | ||
| - ``30m`` |
Contributor
Author
There was a problem hiding this comment.
I'm not sure about what the default value should be.
Feedback is welcome.
Member
There was a problem hiding this comment.
i dont have strong opinion here. 30m looks fine.
findepi
approved these changes
Jul 27, 2022
ebyhr
approved these changes
Jul 27, 2022
Member
|
Merged, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add config
delta.metadata.live-files.cache-ttlfor the caching duration of Delta table active data files.Improvement
Delta Lake connector
Avoid holding indefinitely in the cache the active data files of the Delta Lake tables used already in SQL queries.
Related issues, pull requests, and links
Having this setting, would have probably ensured that the issue #13181 would occur far less often.
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: