Verify schema name length when creating or renaming in Postgres#13307
Merged
Verify schema name length when creating or renaming in Postgres#13307
Conversation
ebyhr
force-pushed
the
ebi/test-long-schema
branch
3 times, most recently
from
35ba5e1 to
b5718c1
Compare
hashhar
reviewed
Aug 3, 2022
| @Override | ||
| public void testRenameSchemaToLongName() | ||
| { | ||
| // Override because the max length is different from CREATE TABLE case |
Member
There was a problem hiding this comment.
The comment feels stale. Or did you mean different from CREATE SCHEMA case?
Member
Author
There was a problem hiding this comment.
Yes, let me fix the comment.
hashhar
reviewed
Aug 3, 2022
| @Override | ||
| protected void verifySchemaNameLengthFailurePermissible(Throwable e) | ||
| { | ||
| assertThat(e).hasMessageMatching("(?s)(.*Read timed out)|(.*\"`NAME`\" that has maximum length of 128.*)"); |
Member
There was a problem hiding this comment.
Is Read timed out a flaky issue or related to larger schema names?
Member
Author
There was a problem hiding this comment.
It relates to larger schema names. (Using long name increases the possibility of read timed out)
ebyhr
force-pushed
the
ebi/test-long-schema
branch
from
b5718c1 to
9f4a756
Compare
hashhar
approved these changes
Aug 4, 2022
ebyhr
force-pushed
the
ebi/test-long-schema
branch
from
9f4a756 to
ab640dc
Compare
Member
Author
|
Rebased on upstream and remove |
ebyhr
force-pushed
the
ebi/test-long-schema
branch
from
ab640dc to
37df4e0
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verify schema name length when creating or renaming in Postgres
Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text: