Improve ClickHouse type mapping documentation#13259
Closed
tangjiangling wants to merge 1 commit intotrinodb:masterfrom
Closed
Improve ClickHouse type mapping documentation#13259tangjiangling wants to merge 1 commit intotrinodb:masterfrom
tangjiangling wants to merge 1 commit intotrinodb:masterfrom
Conversation
10 tasks
tangjiangling
added
the
no-release-notes
ebyhr
reviewed
Jul 21, 2022
| The connector maps ClickHouse types to the corresponding Trino types following this table: | ||
|
|
||
| .. list-table:: ClickHouse type to Trino type mapping | ||
| :widths: 30, 20, 50 |
Member
There was a problem hiding this comment.
25, 25, 50 looks better considering DECIMAL(20,0) in Trino.
| :widths: 30, 20, 50 | ||
| :header-rows: 1 | ||
|
|
||
| * - ClickHouse database type |
Member
There was a problem hiding this comment.
nit: Just "ClickHouse type" is enough to me.
| - ``DOUBLE`` | ||
| - ``DOUBLE`` is an alias of ``Float64`` | ||
| * - ``Decimal`` | ||
| - ``DECIMAL`` |
Member
There was a problem hiding this comment.
Can we add (p, s) to both Decimal & DECIMAL?
| - ``Float64`` | ||
| - | ||
| * - ``DECIMAL`` | ||
| - ``DECIMAL`` |
Member
There was a problem hiding this comment.
Change to Decimal for consistency and it would be better to add (p, s) likes read mapping.
Member
Author
|
Superseded by #13578 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement.
ClickHouse type mapping doc.
N/A.
Related issues, pull requests, and links
Related #11448
Documentation
(x) Sufficient documentation is included in this PR.
Release notes
(x) No release notes entries required.