Avoid writing empty row group in optimized parquet writer#13248
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Jul 23, 2022
Merged
Avoid writing empty row group in optimized parquet writer#13248raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
skrzypo987
approved these changes
Jul 20, 2022
sopel39
approved these changes
Jul 22, 2022
Member
There was a problem hiding this comment.
Is it possible to write a test?
Member
Author
There was a problem hiding this comment.
This is going to get tested via #13246 (validation fails because reader ignores empty row group and counts 1 fewer row group than what the writer wrote), that's how I noticed it.
lib/trino-parquet/src/main/java/io/trino/parquet/writer/ParquetWriter.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
empty-row-group
branch
from
49e5d3b to
c0d8085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improvement
optimized parquet writer
Parquet file written by optimized parquet writer will not contain an extra empty row group
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: