Fix inserting into table with identifiers with quotes

[homar]

Description

Is this change a fix, improvement, new feature, refactoring, or other?

a fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

a connector

How would you describe this change to a non-technical end user or system administrator?

It fixes inserts for tables with columns with quotes in their names

Related issues, pull requests, and links

Fixes: #13074

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Iceberg
* Fix failure when inserting into a Parquet table with columns with quotes in names. ({issue}`13074`)

[alexjo2144]

Maven checks are complaining, but otherwise looks good to me

[alexjo2144]

Can you add a test to BaseIcebergIntegrationTest as well?

[homar]

Maven checks are complaining, but otherwise looks good to me

yeah I forgot about header :D

[homar]

Can you add a test to BaseIcebergIntegrationTest as well?

I thought about that but decided it is more optimal to just unit test this. But sure I can add it.

[homar]

@alexjo2144 comments applied

[electrum]

Shouldn't this have release notes?

[electrum]

I assume the uppercase T is not intentional, and it distracts from the purpose of the test.

[electrum]

Let's call the row x since "a row" sounds like English and blends in with the other identifiers.

[electrum]

ImmutableMap.of() can be hard to read, since the key/value pairs blend together. We can write this as

assertThat(PrimitiveTypeMapBuilder.makeTypeMap(inputTypes, inputColumnNames).containsExactly(
        Map.entry(List.of("an_x20identifier_x20with_x20_x22quotes_x22_x20"), INTEGER),
        Map.entry(List.of("a", "another_x20identifier"), INTEGER));

[homar]

I will do it but with ImmutableList instead of List as I think in general we use ImmutableList much more often

[homar]

Shouldn't this have release notes?

Ok

[ebyhr]

Just added DROP TABLE at the end of test and updated the commit title.

[ebyhr]

Merged, thanks!