Skip to content

Remove redundant comments #13229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Jul 20, 2022
Merged

Remove redundant comments #13229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions core/trino-main/src/main/java/io/trino/operator/scalar/JoniRegexpFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,6 @@ public static int getSearchingOffset(Matcher matcher, int at, int range)
return matcher.searchInterruptible(at, range, Option.DEFAULT);
}
catch (InterruptedException interruptedException) {
// The JONI library is compliant with the InterruptedException contract. They reset the interrupted flag before throwing an exception.
// Since the InterruptedException is being caught the interrupt flag must either be recovered or the thread must be terminated.
// Since we are simply throwing a different exception, the interrupt flag must be recovered to propagate the interrupted status to the upper level code.
Thread.currentThread().interrupt();
throw new TrinoException(GENERIC_USER_ERROR, "" +
"Regular expression matching was interrupted, likely because it took too long. " +
Expand Down
3 changes: 0 additions & 3 deletions core/trino-main/src/main/java/io/trino/type/LikeFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,6 @@ private static int getMatchingOffset(Matcher matcher, int at, int range)
return matcher.matchInterruptible(at, range, Option.NONE);
}
catch (InterruptedException interruptedException) {
// The JONI library is compliant with the InterruptedException contract. They reset the interrupted flag before throwing an exception.
// Since the InterruptedException is being caught the interrupt flag must either be recovered or the thread must be terminated.
// Since we are simply throwing a different exception, the interrupt flag must be recovered to propagate the interrupted status to the upper level code.
Thread.currentThread().interrupt();
throw new TrinoException(GENERIC_USER_ERROR, "" +
"Regular expression matching was interrupted, likely because it took too long. " +
Expand Down