Rename ambiguous variable in JoinUtils#13211
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Aug 4, 2022
yikf:joinNode-ambiguity
Merged
Rename ambiguous variable in JoinUtils#13211raunaqmorarka merged 1 commit intotrinodb:masterfrom yikf:joinNode-ambiguity
raunaqmorarka merged 1 commit intotrinodb:masterfrom
yikf:joinNode-ambiguity
Conversation
Contributor
Author
|
@findepi This is a minor fix for variable naming |
Praveen2112
reviewed
Jul 19, 2022
core/trino-main/src/main/java/io/trino/operator/join/JoinUtils.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
approved these changes
Aug 2, 2022
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
Please squash your commits
Contributor
Author
done |
core/trino-main/src/main/java/io/trino/operator/join/JoinUtils.java
Outdated
Show resolved
Hide resolved
yikf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr aims to fix a minor problem with variable naming, Variable
joinNodeinJoinUtils.isBuildSideReplicatedshould berightNode.