Skip to content

Avoid overriding nullability decision #13152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martint merged 1 commit into from
Jul 13, 2022
Merged

Avoid overriding nullability decision #13152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/sql/planner/NullabilityAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ protected Void visitCast(Cast node, AtomicBoolean result)
// except for the CAST(NULL AS x) case -- we should fix this at some point)
//
// Also, try_cast (i.e., safe cast) can return null
result.set(node.isSafe() || !node.isTypeOnly());
result.compareAndSet(false, node.isSafe() || !node.isTypeOnly());
Copy link
Copy Markdown
Member

@findepi findepi Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result.set(result.get && ...) would be clearer, since we're not using any concurrency here

return null;
}

Expand Down
34 changes: 34 additions & 0 deletions core/trino-main/src/test/java/io/trino/sql/query/TestJoin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,40 @@ public void testJoinOnNan()
.matches("VALUES (nan(), nan())");
}

@Test
public void testJoinWithComplexCriteria()
{
// Test for https://github.com/trinodb/trino/issues/13145
// The issue happens because ReorderJoins evaluates candidates for equality inference
// based on one form of the join criteria (i.e., CAST(...) = CASE ... END)) and then
// attempts to make reformulate the join criteria based on another form of the expression
// with the terms flipped (i.e., CASE ... END = CAST(...)). Because NullabilityAnalyzer.mayReturnNullOnNonNullInput
// could return an inconsistent result for both forms, the expression ended being dropped
// from the join clause.
assertThat(assertions.query("" +
"WITH " +
" t1 (id, v) as ( " +
" VALUES " +
" (1, 100), " +
" (2, 200) " +
" ), " +
" t2 (id, x, y) AS ( " +
" VALUES\n" +
" (1, 10, 'a'), " +
" (2, 10, 'b') " +
" ), " +
" t AS ( " +
" SELECT " +
" x " +
" , IF(t1.v = 0, 'cc', y) as z " +
" FROM t1 JOIN t2 ON (t1.id = t2.id) " +
" ) " +
"SELECT * " +
"FROM t " +
"WHERE x = 10 AND z = 'b'"))
.matches("VALUES (10, CAST('b' AS varchar(2)))");
}

@Test
public void testInPredicateInJoinCriteria()
{
Expand Down