Skip to content

Add comment option in CREATE VIEW documentation#13143

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/docs-create-view-with-comment
Jul 13, 2022
Merged

Add comment option in CREATE VIEW documentation#13143
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/docs-create-view-with-comment

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jul 11, 2022

Description

Add comment option in CREATE VIEW documentation
https://github.com/trinodb/trino/blob/master/core/trino-parser/src/main/antlr4/io/trino/sql/parser/SqlBase.g4#L86-L88

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Jul 11, 2022
@github-actions github-actions bot added the docs label Jul 11, 2022
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concise and correct... but could we maybe add an example.

@ebyhr ebyhr force-pushed the ebi/docs-create-view-with-comment branch from aca2db5 to 120ec18 Compare July 13, 2022 05:43
@ebyhr ebyhr force-pushed the ebi/docs-create-view-with-comment branch from 120ec18 to 2f86b66 Compare July 13, 2022 06:02
@ebyhr ebyhr merged commit ad86377 into trinodb:master Jul 13, 2022
@ebyhr ebyhr deleted the ebi/docs-create-view-with-comment branch July 13, 2022 06:56
@github-actions github-actions bot added this to the 390 milestone Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants