Implement getReadTimeNanos for JdbcRecordCursor#13132
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Aug 2, 2022
Merged
Implement getReadTimeNanos for JdbcRecordCursor#13132raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestJdbcRecordSetProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcRecordCursor.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestJdbcRecordSet.java
Outdated
Show resolved
Hide resolved
87c6484 to
b9a94ad
Compare
findepi
reviewed
Jul 20, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcModule.java
Outdated
Show resolved
Hide resolved
756bb30 to
0df0e7e
Compare
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcRecordCursor.java
Outdated
Show resolved
Hide resolved
0df0e7e to
679ffed
Compare
raunaqmorarka
approved these changes
Aug 2, 2022
Closed
Member
|
Would it be reasonable to put this release note in the JDBC driver section rather than all of the JDBC-based connectors? |
Member
This is not related to the Trino JDBC driver. It's about JDBC-based connectors reporting the wall time spent in reading data from the external system to the engine so that it can be shown in EXPLAIN ANALYZE VERBOSE, web ui and reported to the event listeners. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the
getReadTimeNanosmethod inJdbcRecordCursorso thatphysicalInputReadTimewill represent how long was spent reading data.This will also show up in a in
EXPLAIN ANALYZE VERBOSEoutput for scans on JDBC connectors. For example, with this change aTableScanoperator against a MySQL table shows physical input read time in connector metrics:Minor improvement.
Related issues, pull requests, and links
Documentation
( X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
() No release notes entries required.
(x) Release notes entries required with the following suggested text: