Skip to content

Drop unused properties from cassandra#13128

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
tangjiangling:drop-unused-properties-from-cassandra
Jul 9, 2022
Merged

Drop unused properties from cassandra#13128
ebyhr merged 1 commit intotrinodb:masterfrom
tangjiangling:drop-unused-properties-from-cassandra

Conversation

@tangjiangling
Copy link
Copy Markdown
Member

@tangjiangling tangjiangling commented Jul 8, 2022

With the introduction of Cassandra driver v4 via PR #7828 there are a few
properties that are not anymore needed:

  • cassandra.load-policy.use-token-aware
  • cassandra.load-policy.shuffle-replicas
  • cassandra.load-policy.allowed-addresses

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Fix.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Cassandra connector.

How would you describe this change to a non-technical end user or system administrator?

Drop unused properties.

Related issues, pull requests, and links

Fixes #12223

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Cassandra
* Remove `cassandra.load-policy.use-token-aware`, `cassandra.load-policy.shuffle-replicas` and `cassandra.load-policy.allowed-addresses` configuration property. ({issue}`12223`)

@cla-bot cla-bot bot added the cla-signed label Jul 8, 2022
@github-actions github-actions bot added the docs label Jul 8, 2022
@tangjiangling tangjiangling marked this pull request as ready for review July 8, 2022 15:37
@tangjiangling tangjiangling requested a review from findinpath July 8, 2022 15:37
With the introduction of Cassandra driver v4 via PR trinodb#7828 there are a few
properties that are not anymore needed:

- cassandra.load-policy.use-token-aware
- cassandra.load-policy.token-aware.shuffle-replicas
- cassandra.load-policy.allowed-addresses
@tangjiangling tangjiangling force-pushed the drop-unused-properties-from-cassandra branch from f217459 to 1359e30 Compare July 8, 2022 16:14
@ebyhr ebyhr merged commit 6ce807f into trinodb:master Jul 9, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jul 9, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 390 milestone Jul 9, 2022
@ebyhr ebyhr mentioned this pull request Jul 9, 2022
@tangjiangling tangjiangling deleted the drop-unused-properties-from-cassandra branch July 9, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Drop unused properties from cassandra

2 participants