Merged
Conversation
The `force-spilling-join-operator` config flag and the corresponding session property might have not been working properly and produce ClassCastException.
| int taskConcurrency = getTaskConcurrency(session); | ||
| OperatorFactory hashBuilderOperatorFactory; | ||
| if (useSpillingJoinOperator()) { | ||
| if (useSpillingJoinOperator(session)) { |
Member
There was a problem hiding this comment.
Can we rely on spillEnabled instead of isSpillEnabled(session) in useSpillingJoinOperator ?
Member
Author
There was a problem hiding this comment.
That make sense. I added another commit with that change
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Show resolved
Hide resolved
added 2 commits
July 11, 2022 11:39
Use `spillEnabled` local variable instead of session property. That way the new non-spilling join operator will be used in the case of spilling enabled by session property but disabled because of different reasons.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
force-spilling-join-operatorconfig flag and the corresponding sessionproperty might have not been working properly and produce ClassCastException.
Description
fix
core query engine
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: