Fix incorrect pushdown of expression below join#13110
Closed
martint wants to merge 1 commit intotrinodb:masterfrom
Closed
Fix incorrect pushdown of expression below join#13110martint wants to merge 1 commit intotrinodb:masterfrom
martint wants to merge 1 commit intotrinodb:masterfrom
Conversation
PushInequalityFilterExpressionBelowJoin was incorrectly pushing a projection into the inner side of an outer join. This is an invalid transformation when the outer join produces a null for the columns of the inner table in case of a mismatch and the expression that's pushed down does not preserve nulls. As a temporary fix, limit the scope of the rule only to inner joins.
Member
Author
|
cc @lukasz-stec |
Member
|
More targeted fix for #13114. It will still pushdown predicates within outer join so that outer join can take advantage of faster ineq join execution ( |
Member
Author
|
Superseded by #13114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PushInequalityFilterExpressionBelowJoin was incorrectly
pushing a projection into the inner side of an outer join.
This is an invalid transformation when the outer join produces
a null for the columns of the inner table in case of a mismatch
and the expression that's pushed down does not preserve nulls.
As a temporary fix, limit the scope of the rule only to inner joins.
Fixes #13109
Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text: