Expose AWS Glue metastore stats via JMX#13087
Conversation
|
nit: |
e8af62c to
7c818a0
Compare
|
Can we add a test ? |
@raunaqmorarka Due to the fact that Trino does not currently have a a product test environment specific for Glue (see #5426) for Hive / Iceberg, I can create a product test only for Delta Lake. Integration Tests depend on the |
8ec95f2 to
f0960d6
Compare
f0960d6 to
840f2f2
Compare
The stats are exposed in JMX under the following object names: - hive: "trino.plugin.hive.metastore.glue:type=GlueHiveMetastore,name=hive" - iceberg: "io.trino.plugin.hive.metastore.glue:type=GlueMetastoreStats,name=iceberg" - delta: "io.trino.plugin.hive.metastore.glue:type=GlueHiveMetastore,name=delta"
840f2f2 to
da21bea
Compare
|
Merged, thanks! |
| } | ||
|
|
||
| @Managed | ||
| @Flatten |
There was a problem hiding this comment.
@dain you removed these two annotations in a commit here: a4142de#diff-d827fd361f2fef94d35ef8593d0f9a7f168366f28acdb88a67ff413b1904a3d0
Was that on purpose?
Description
Expose the Glue Hive Metastore stats over JMX.
Even though the Glue stats were previously collected, due to a regression issue, they weren't exposed by JMX.
The stats are exposed in JMX under the following object names:
Fix
Hive connector
Expose the Glue Hive Metastore stats over JMX.
In Trino, the users could issue a statement like the following to retrieve the AWS Glue stats in the connectors backed by AWS Glue.
For Hive:
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: