Skip to content

Remove deprecated version of ConnectorRecordSetProvider#getRecordSet #13084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunaqmorarka merged 2 commits into from
Jul 5, 2022
Merged

Remove deprecated version of ConnectorRecordSetProvider#getRecordSet #13084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f2cfec
Remove usage of deprecated getRecordSet in KinesisRecordSetProvider
raunaqmorarka Jul 5, 2022
35c4081
Remove deprecated version of ConnectorRecordSetProvider#getRecordSet
raunaqmorarka Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorRecordSetProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,6 @@ default RecordSet getRecordSet(
ConnectorSplit split,
ConnectorTableHandle table,
List<? extends ColumnHandle> columns)
{
return getRecordSet(transaction, session, split, columns);
}

@Deprecated
default RecordSet getRecordSet(
ConnectorTransactionHandle transactionHandle,
ConnectorSession session,
ConnectorSplit split,
List<? extends ColumnHandle> columns)
{
throw new UnsupportedOperationException("getRecordSet() must be implemented");
}
Expand Down
8 changes: 0 additions & 8 deletions ...main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorRecordSetProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,4 @@ public RecordSet getRecordSet(ConnectorTransactionHandle transaction, ConnectorS
return new ClassLoaderSafeRecordSet(delegate.getRecordSet(transaction, session, split, table, columns), classLoader);
}
}

@Override
public RecordSet getRecordSet(ConnectorTransactionHandle transactionHandle, ConnectorSession session, ConnectorSplit split, List<? extends ColumnHandle> columns)
{
try (ThreadContextClassLoader ignored = new ThreadContextClassLoader(classLoader)) {
return new ClassLoaderSafeRecordSet(delegate.getRecordSet(transactionHandle, session, split, columns), classLoader);
}
}
}
2 changes: 2 additions & 0 deletions plugin/trino-kinesis/src/main/java/io/trino/plugin/kinesis/KinesisRecordSetProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import io.trino.spi.connector.ConnectorRecordSetProvider;
import io.trino.spi.connector.ConnectorSession;
import io.trino.spi.connector.ConnectorSplit;
import io.trino.spi.connector.ConnectorTableHandle;
import io.trino.spi.connector.ConnectorTransactionHandle;
import io.trino.spi.connector.RecordSet;

Expand Down Expand Up @@ -54,6 +55,7 @@ public RecordSet getRecordSet(
ConnectorTransactionHandle transactionHandle,
ConnectorSession session,
ConnectorSplit split,
ConnectorTableHandle table,
List<? extends ColumnHandle> columns)
{
KinesisSplit kinesisSplit = (KinesisSplit) split;
Expand Down