Conversation
findinpath
reviewed
Jul 7, 2022
...n/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksCreateTableCompatibility.java
Show resolved
Hide resolved
...n/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksCreateTableCompatibility.java
Outdated
Show resolved
Hide resolved
...n/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksCreateTableCompatibility.java
Outdated
Show resolved
Hide resolved
...n/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksCreateTableCompatibility.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Jul 7, 2022
Contributor
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
LGTM
Can you please issue a copy of the PR with secrets?
Does the duration of the suite suite-delta-lake-databricks fit within 130m time limit (as configured in ci.yml ?
Member
Author
I sent this PR to upstream directly, so it runs with secrets.
The previous CI passed, but let's re-confirm the latest result. |
Praveen2112
approved these changes
Jul 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test environment for Databricks 10.4
Documentation
(x) Sufficient documentation is included in this PR.
Release notes
(x) Release notes entries required with the following suggested text: