Closed
Conversation
- Fix typo - Inline variable - Remove unused parameter
The previous name `maxActiveSplit*` was not very readable, so it has been renamed.
Co-authored-by: Yingjie Luan <1275963@gmail.com>
tangjiangling
requested review from
arhimondr,
electrum,
jhlodin,
losipiuk and
phd3
For regular expression matching, especially when using the Joni regular library, this may cause the task thread to take so long that it looks like a dead loop, which may result in no free threads for the worker to process other splits. Since the Joni regular library supports handling interrupts, this commit gives the task thread a chance to exit by interrupting the task thread of Joni regular functions that has been running for a long time. Co-authored-by: Yingjie Luan <1275963@gmail.com>
tangjiangling
force-pushed
the
interrupt_runaway_splits
branch
from
11aabcf to
568fbe3
Compare
Member
Author
|
@arhimondr PTAL |
Contributor
|
Hey, thanks for helping! Can you help with with #12392! I would really appreciate that! I can add you as coauthor. |
Member
Author
|
Close this PR and continue on #12392. (There are some code cleanup commits that I will re-file PR) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For regular expression matching, especially when using the Joni regular library,
this may cause the task thread to take so long that it looks like a dead loop,
which may result in no free threads for the worker to process other splits.
Since the Joni regular library supports handling interrupts, this PR gives
the task thread a chance to exit by interrupting the task thread of Joni regular
functions that has been running for a long time.
Co-authored-by: @leetcode-1533
Description
Fix.
Core query engine.
Fix potential deadlock during execution of Joni regular functions.
Related issues, pull requests, and links
Superceding #12392
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: