Skip to content

Set valid classloader for Iceberg CTAS with delete files#13036

Closed
homar wants to merge 1 commit intotrinodb:masterfrom
homar:homar/invalid_class_loader_user_in_iceberg_page_source
Closed

Set valid classloader for Iceberg CTAS with delete files#13036
homar wants to merge 1 commit intotrinodb:masterfrom
homar:homar/invalid_class_loader_user_in_iceberg_page_source

Conversation

@homar
Copy link
Copy Markdown
Member

@homar homar commented Jun 29, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

iceberg connector

How would you describe this change to a non-technical end user or system administrator?

a fix for a problem which could occurre in a very specific situation

Related issues, pull requests, and links

#13035

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 29, 2022
@homar homar force-pushed the homar/invalid_class_loader_user_in_iceberg_page_source branch from e51ae57 to e92eff8 Compare June 30, 2022 10:36
@findinpath
Copy link
Copy Markdown
Contributor

I've tried to test the code on this branch and ran into the following problem:

trino:default> create table iceberg.default.lineitem as select * from tpch.sf1.lineitem;
CREATE TABLE: 6001215 rows

Query 20220704_104259_00001_p7usw, FINISHED, 1 node
Splits: 22 total, 22 done (100.00%)
31.61 [6M rows, 0B] [190K rows/s, 0B/s]

trino:default> delete from iceberg.default.lineitem where extendedprice = 1000;

Query 20220704_104337_00002_p7usw, FAILED, 1 node
Splits: 11 total, 0 done (0.00%)
1.55 [0 rows, 0B] [0 rows/s, 0B/s]

Query 20220704_104337_00002_p7usw failed: UpdatablePageSource not set

@homar homar force-pushed the homar/invalid_class_loader_user_in_iceberg_page_source branch 2 times, most recently from c0e4a2a to 208a6ed Compare July 18, 2022 13:04
Add ClassLoaderSafeConnectorPageSource and use it from
ClassLoaderSafeConnectorPageSourceProvider to provide
class loaders safety.
@homar homar force-pushed the homar/invalid_class_loader_user_in_iceberg_page_source branch from 208a6ed to c38e996 Compare July 18, 2022 14:21
@homar homar closed this Jul 19, 2022
@homar homar deleted the homar/invalid_class_loader_user_in_iceberg_page_source branch July 19, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants