Skip to content

Add missing syntax in table functions docs #13019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
findepi merged 1 commit into from
Jun 28, 2022
Merged

Add missing syntax in table functions docs #13019

findepi merged 1 commit into from
Jun 28, 2022

Conversation

@nineinchnick
Copy link
Member

@nineinchnick nineinchnick commented Jun 28, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?
fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
docs

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 28, 2022
@nineinchnick nineinchnick requested review from findepi, kasiafi and mosabua and removed request for kasiafi June 28, 2022 14:16
@nineinchnick nineinchnick added no-release-notes This pull request does not require release notes entry docs labels Jun 28, 2022
kasiafi
kasiafi approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@kasiafi kasiafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@findepi findepi merged commit dcbf793 into trinodb:master Jun 28, 2022
@github-actions github-actions bot added this to the 388 milestone Jun 28, 2022
@colebow colebow mentioned this pull request Jun 28, 2022
Merged
@mosabua
Copy link
Member

mosabua commented Jun 28, 2022

Thanks @nineinchnick !

@nineinchnick nineinchnick deleted the table-function-syntax-docs branch July 25, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kasiafi kasiafi kasiafi approved these changes

@mosabua mosabua Awaiting requested review from mosabua

@findepi findepi Awaiting requested review from findepi

Assignees

No one assigned

Labels

cla-signed docs no-release-notes This pull request does not require release notes entry

Milestone

388

Development

Successfully merging this pull request may close these issues.

4 participants

@nineinchnick @mosabua @kasiafi @findepi