Skip to content

Conversation

@sheajamba
Copy link
Member

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improved table structure for "Thrift metastore configuration properties" Now a list table.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Connector docs.

How would you describe this change to a non-technical end user or system administrator?

New table structure is easier to maintain.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 28, 2022
@sheajamba sheajamba requested a review from mosabua June 28, 2022 14:01
@github-actions github-actions bot added the docs label Jun 28, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for drop table operations? Also ... "doesn't do it"

Maybe

Actively delete the files for drop table operations, for cases when the metastore does not delete the files.

@sheajamba sheajamba force-pushed the hive-metastore-docs branch from a8a8265 to dca9e4e Compare June 28, 2022 19:21
@sheajamba sheajamba requested a review from mosabua June 28, 2022 19:23
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@martint martint merged commit 5bc8d88 into trinodb:master Jun 29, 2022
@github-actions github-actions bot added this to the 388 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants