Remove @Deprecated from OidcDiscoveryConfig fields#13013
Merged
kokosing merged 2 commits intotrinodb:masterfrom Aug 11, 2022
Merged
Remove @Deprecated from OidcDiscoveryConfig fields#13013kokosing merged 2 commits intotrinodb:masterfrom
kokosing merged 2 commits intotrinodb:masterfrom
Conversation
Using deprecated annotations had unintended consequence of printing deprecation warnings even when these properties are actually used for providing additional configuration.
lukasz-walkiewicz
requested review from
Laonel,
Praveen2112,
atanasenko,
huberty89 and
s2lomon
huberty89
approved these changes
Aug 9, 2022
Laonel
approved these changes
Aug 11, 2022
kokosing
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
@Deprecatedfrom OidcDiscoveryConfig fieldsUsing deprecated annotations had unintended consequence of printing
deprecation warnings even when these properties are actually used
for providing additional configuration.
Additionally, simplify logic of getting value of OIDC field.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: