Describe record cursor type mapping in dev guide#12976
Merged
martint merged 1 commit intotrinodb:masterfrom Aug 22, 2022
Merged
Describe record cursor type mapping in dev guide#12976martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
nineinchnick
added
no-release-notes
colebow
reviewed
Jun 28, 2022
Member
colebow
left a comment
colebow
left a comment
There was a problem hiding this comment.
This overall looks good to me, though I definitely don't know enough about the subject matter to review for correctness / accuracy.
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
from
6637faf to
d0ccd07
Compare
MiguelWeezardo
requested review from
MiguelWeezardo
and removed request for
MiguelWeezardo
Member
|
Looks good |
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
3 times, most recently
from
4f6ba91 to
f2ca2b1
Compare
martint
reviewed
Jul 24, 2022
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
3 times, most recently
from
902d4b3 to
6b0bbe3
Compare
nineinchnick
commented
Jul 24, 2022
Member
Author
|
@martint PTAL |
martint
reviewed
Jul 27, 2022
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
from
6b0bbe3 to
57e322c
Compare
Member
Author
|
@martint AC, PTAL, and thanks so much! |
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
from
57e322c to
c02cb9f
Compare
Member
Author
jhlodin
reviewed
Aug 2, 2022
Contributor
jhlodin
left a comment
jhlodin
left a comment
There was a problem hiding this comment.
Some suggested style and formatting edits
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
from
c02cb9f to
49c7153
Compare
Member
Author
|
@martint PTAL |
martint
reviewed
Aug 19, 2022
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
from
49c7153 to
218a5bd
Compare
Member
Author
|
@martint there are still two unresolved comments where I asked for clarification, PTAL. |
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
from
218a5bd to
6056706
Compare
nineinchnick
force-pushed
the
dev-guide-record-sets
branch
from
6056706 to
7a9b0f2
Compare
Member
Author
|
@martint all done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe how to map types when implementing a
RecordCursor, like how to encode strings into slices or pack timestamps. Add some basic examples of creating blocks.Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: