Test: Adapt Delta product tests for execution on top of Databricks backed by AWS Glue#12973
Closed
Test: Adapt Delta product tests for execution on top of Databricks backed by AWS Glue#12973
Conversation
fd783e3 to
de441ae
Compare
Member
Author
|
Updated to current state of #12896 |
de441ae to
6a07350
Compare
Member
Author
|
Updated to current state of #12896 |
6a07350 to
896d4e3
Compare
Member
|
@findinpath Updated to the latest status. |
896d4e3 to
b72808b
Compare
b72808b to
6f3425b
Compare
Member
Author
|
Updated to current state of #12896 |
As part of the open sourcing process of the product tests for the `trino-delta-lake` connector, the product tests dedicated for the Databricks runtime were dependent on Hive Metastore Service. However, using AWS Glue comes with the advantage of not managing an extra service for running product tests against the Databricks runtime. This is why the product tests are now adapted to run with AWS Glue as metastore service for the Databricks runtime.
When trying to create tables on Databricks on the schema `extraordinary`, the creation of the tables was failing with the message: ``` Error in SQL statement: IllegalArgumentException: Path must be absolute: test100-__PLACEHOLDER__ ``` Specifying the location for the custom schema helps avoiding the above-mentioned issue.
The tests in the class TestHiveAndDeltaLakeRedirect run on both Delta OSS and Databricks infrastructure and not only on Databricks.
Avoid running into a test failure when dealing with a test depending on Databricks AWS S3 and AWS Glue environment. Consult for further details: #13017
Tables created for testing purposes on AWS Glue / AWS S3 have to be eventually removed. Use the prefix "test_" to identify easier the tests in the routine responsible for removing the test Glue tables.
6f3425b to
e73186f
Compare
Member
|
Updated to current state of #12896 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test #12896 with secrets
cc @findinpath @alexjo2144 @ebyhr