Skip to content

Test: Adapt Delta product tests for execution on top of Databricks backed by AWS Glue#12973

Closed
findepi wants to merge 10 commits intomasterfrom
findepi/test/12896/delta-lake-test-with-databricks
Closed

Test: Adapt Delta product tests for execution on top of Databricks backed by AWS Glue#12973
findepi wants to merge 10 commits intomasterfrom
findepi/test/12896/delta-lake-test-with-databricks

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jun 24, 2022

Test #12896 with secrets

cc @findinpath @alexjo2144 @ebyhr

@cla-bot cla-bot bot added the cla-signed label Jun 24, 2022
@findepi findepi force-pushed the findepi/test/12896/delta-lake-test-with-databricks branch 2 times, most recently from fd783e3 to de441ae Compare June 27, 2022 07:37
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 27, 2022

Updated to current state of #12896

@findepi findepi force-pushed the findepi/test/12896/delta-lake-test-with-databricks branch from de441ae to 6a07350 Compare June 28, 2022 15:41
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 28, 2022

Updated to current state of #12896

@ebyhr ebyhr force-pushed the findepi/test/12896/delta-lake-test-with-databricks branch from 6a07350 to 896d4e3 Compare June 29, 2022 13:35
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 29, 2022

@findinpath Updated to the latest status.

@ebyhr ebyhr force-pushed the findepi/test/12896/delta-lake-test-with-databricks branch from 896d4e3 to b72808b Compare June 29, 2022 16:17
@findepi findepi force-pushed the findepi/test/12896/delta-lake-test-with-databricks branch from b72808b to 6f3425b Compare June 30, 2022 15:39
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jun 30, 2022

Updated to current state of #12896

As part of the open sourcing process of the product tests for the `trino-delta-lake`
connector, the product tests dedicated for the Databricks runtime were dependent
on Hive Metastore Service.

However, using AWS Glue comes with the advantage of not managing an extra service
for running product tests against the Databricks runtime. This is why the product
tests are now adapted to run with AWS Glue as metastore service for the
Databricks runtime.
When trying to create tables on Databricks on the
schema `extraordinary`, the creation of the tables
was failing with the message:

```
Error in SQL statement: IllegalArgumentException: Path must be absolute: test100-__PLACEHOLDER__
```

Specifying the location for the custom schema helps
avoiding the above-mentioned issue.
The tests in the class TestHiveAndDeltaLakeRedirect run on both
Delta OSS and Databricks infrastructure and not only on Databricks.
Avoid running into a test failure when dealing with a
test depending on Databricks AWS S3 and AWS Glue environment.

Consult for further details:

#13017
Tables created for testing purposes on AWS Glue / AWS S3
have to be eventually removed.
Use the prefix "test_" to identify easier the tests
in the routine responsible for removing the test Glue tables.
@ebyhr ebyhr force-pushed the findepi/test/12896/delta-lake-test-with-databricks branch from 6f3425b to e73186f Compare July 4, 2022 07:19
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jul 4, 2022

Updated to current state of #12896

@findepi findepi closed this Jul 21, 2022
@findepi findepi deleted the findepi/test/12896/delta-lake-test-with-databricks branch July 21, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants