Skip to content

Fix documentation for EXCEPT/INTERSECT#12962

Merged
martint merged 1 commit intotrinodb:masterfrom
aaneja:fix-except-intersect-doc
Jul 10, 2022
Merged

Fix documentation for EXCEPT/INTERSECT#12962
martint merged 1 commit intotrinodb:masterfrom
aaneja:fix-except-intersect-doc

Conversation

@aaneja
Copy link
Copy Markdown
Contributor

@aaneja aaneja commented Jun 23, 2022

ALL support was added in #5890
Documentation wasn't updated however

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 23, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@github-actions github-actions bot added the docs label Jun 23, 2022
@findepi
Copy link
Copy Markdown
Member

findepi commented Jun 23, 2022

can you please make sure you filled the CLA? For more information, see https://github.com/trinodb/cla.

@aaneja aaneja force-pushed the fix-except-intersect-doc branch from c617f56 to f0f7448 Compare June 23, 2022 21:47
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 23, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Anant Aneja.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@aaneja aaneja force-pushed the fix-except-intersect-doc branch from f0f7448 to e051632 Compare June 23, 2022 21:58
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 23, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@aaneja
Copy link
Copy Markdown
Contributor Author

aaneja commented Jun 24, 2022

@findepi I signed the CLA yesterday

@colebow
Copy link
Copy Markdown
Member

colebow commented Jun 24, 2022

I'll make sure that gets looked at ASAP.

@martint
Copy link
Copy Markdown
Member

martint commented Jun 30, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jun 30, 2022
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 30, 2022

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space after ALL

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@aaneja aaneja force-pushed the fix-except-intersect-doc branch from e051632 to 3dc11c8 Compare July 5, 2022 20:04
@aaneja
Copy link
Copy Markdown
Contributor Author

aaneja commented Jul 9, 2022

This is ready to merge

@martint martint merged commit 3737ba0 into trinodb:master Jul 10, 2022
@github-actions github-actions bot added this to the 390 milestone Jul 10, 2022
@aaneja aaneja deleted the fix-except-intersect-doc branch July 10, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants