Cleanup TestDeltaLakeDropTableCompatibility #12960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `Engine` interface (local to this test) and replace its use with the `Engine` enum used in other tests.
findepi
added
test
no-release-notes
phd3
approved these changes
Jun 23, 2022
| import static io.trino.tests.product.TestGroups.DELTA_LAKE_OSS; | ||
| import static io.trino.tests.product.TestGroups.PROFILE_SPECIFIC_TESTS; | ||
| import static io.trino.tests.product.hive.Engine.DELTA; | ||
| import static io.trino.tests.product.hive.Engine.TRINO; |
Member
There was a problem hiding this comment.
nit: Engine can be moved out of .....product.hive, pre-existing though.
findepi
deleted the
findepi/cleanup-testdeltalakedroptablecompatibility-8fe0d5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Engineinterface (local to this test) and replace its use withthe
Engineenum used in other tests.