Use unique table locations in Iceberg by default#12941
Merged
findepi merged 1 commit intotrinodb:masterfrom Aug 1, 2022
Merged
Use unique table locations in Iceberg by default#12941findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
findinpath
reviewed
Jun 23, 2022
Contributor
There was a problem hiding this comment.
The test for the default value should be also adjusted.
f86b557 to
9d0eafb
Compare
Member
|
@alexjo2144 you need to rebase |
findepi
approved these changes
Jun 23, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
...no-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToIceberg.java
Outdated
Show resolved
Hide resolved
...no-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToIceberg.java
Outdated
Show resolved
Hide resolved
...sts/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkDropTableCompatibility.java
Outdated
Show resolved
Hide resolved
...sts/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkDropTableCompatibility.java
Outdated
Show resolved
Hide resolved
9d0eafb to
d107f5e
Compare
Member
Author
|
All set, thank you all for the reviews |
findepi
reviewed
Jun 24, 2022
Member
There was a problem hiding this comment.
String location = m.group(1);
verify(!m.find(), "Unexpected second match");
return location;
d107f5e to
b566c43
Compare
Member
Author
|
Updated. @findepi might be worth running with secrets for Glue? |
This was referenced Jun 24, 2022
Member
|
Test PR with secrets: #12981 |
Member
Author
|
CI: #12950 |
b566c43 to
0ddd006
Compare
Member
Author
|
Rebased for conflicts |
Member
Author
Member
Author
losipiuk
reviewed
Jul 21, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMaterializedViewTest.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jul 21, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMaterializedViewTest.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jul 21, 2022
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergPartitionEvolution.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Jul 21, 2022
7179028 to
83992ad
Compare
homar
approved these changes
Jul 29, 2022
83992ad to
7b8067f
Compare
7b8067f to
866ddb0
Compare
Member
Author
|
Checks are passing ✔️ |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable the unique table location feature by default in the Iceberg connector
Enabling an existing feature by default
Iceberg connector
Related issues, pull requests, and links
Fixes: #5632
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: